This repository has been archived by the owner on Jul 20, 2018. It is now read-only.
Add checks for trigger_error and set_error_handler #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add checks per issue Automattic#272: > trigger_error() doesn't make much sense, as there is no access to the log file this will produce...and if you intentionally throw a fatal error, that's doubly bad. > set_error_handler() is not supported. Test cases also added
Use spaces instead of tabs to be consistent with the rest of the code
Add trigger_error and set_error_handler to test file for use in test-VIPRestrictedPatternsCheck
nickdaugherty
added a commit
that referenced
this pull request
May 22, 2015
Add checks for trigger_error and set_error_handler
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checks per issue #272:
Relevant tests are also added