Extend vipgoci_runtime_measure_shell_exec() with retry capabilities, and rename function #253

gudmdharalds · 2022-02-28T19:38:35Z

Extend vipgoci_runtime_measure_shell_exec() with retry capabilities, and rename function.

Implement retry capability for vipgoci_runtime_measure_shell_exec() function.
Rename vipgoci_runtime_measure_shell_exec() to vipgoci_runtime_measure_shell_exec_with_retry().
Update unit test to fit WordPress Coding Standards.
Add integration-test for retry mechanism
Add or update PHPDoc comments for new or updated functions (main code only)
Changelog entry [ Changelog for version 1.2.1 #254 ]
Exchange shell_exec() usage with vipgoci_runtime_measure_shell_exec_with_retry() [ Use vipgoci_runtime_measure_shell_exec() where possible #155 ]
Check if return from vipgoci_runtime_measure_shell_exec_with_retry() is checked everywhere.
Check automated unit-tests

…e_shell_exec_with_retry()

wpcomvip-vipgoci-bot

phpcs scanning turned up:

🚫 3 errors

This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

Scan run detail

Software versions vip-go-ci version: `1.2.0` PHP runtime version for vip-go-ci: `8.1.3` PHP runtime version for PHP linting: `8.1.3` PHP runtime version for PHPCS: `7.4.28` PHPCS version: `3.6.2` Options file (`.vipgoci_options`) Options file enabled: `true` Configurable options: `skip-execution` `skip-draft-prs` `lint-modified-files-only` `phpcs` `phpcs-severity` `phpcs-sniffs-include` `phpcs-sniffs-exclude` `report-no-issues-found` `review-comments-sort` `review-comments-include-severity` `post-generic-pr-support-comments` `review-comments-sort` `scan-details-msg-include` `svg-checks` `autoapprove` `autoapprove-php-nonfunctional-changes` `hashes-api` Options altered: `phpcs-severity`set to`1` `phpcs-sniffs-include`set to`Generic.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode` `phpcs-sniffs-exclude`set to`WordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax` `skip-draft-prs`set to	PHP lint options PHP lint files enabled: `true` Lint modified files only: `true` Directories not PHP linted: None SVG configuration SVG scanning enabled: `true` Auto-approval configuration Auto-approvals enabled: `true` Non-functional changes auto-approved: `true` Auto-approval DB enabled: `true` Auto-approved file-types: `css` `csv` `eot` `gif` `gz` `ico` `ini` `jpeg` `jpg` `json` `less` `map` `md` `mdown` `mo` `mp4` `otf` `pcss` `pdf` `po` `pot` `png` `sass` `scss` `styl` `ttf` `txt` `woff` `woff2` `yml`	PHPCS configuration PHPCS scanning enabled: `true` PHPCS severity level: `1` Standard(s) used: `PHPCompatibility` `PHPCompatibilityParagonieRandomCompat` `PHPCompatibilityParagonieSodiumCompat` `VariableAnalysis` `WordPress` Runtime set: `testVersion 8.1-` Custom sniffs included: `Generic.PHP.DisallowShortOpenTag` `Squiz.PHP.CommentedOutCode` Custom sniffs excluded: `WordPress.Security.EscapeOutput` `WordPress.PHP.DevelopmentFunctions` `WordPress.WP.AlternativeFunctions` `WordPress.PHP.DiscouragedPHPFunctions` `WordPress.Files.FileName` `Squiz.Commenting.FileComment` `Generic.PHP.Syntax` Directories not PHPCS scanned: `tests/unit`

tests/integration/helper-scripts/cli-predictably-fails.php

Dismissing review as all inline comments are obsolete by now

wpcomvip-vipgoci-bot

phpcs scanning turned up:

🚫 2 errors

This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

Scan run detail

Software versions vip-go-ci version: `1.2.0` PHP runtime version for vip-go-ci: `8.1.3` PHP runtime version for PHP linting: `8.1.3` PHP runtime version for PHPCS: `7.4.28` PHPCS version: `3.6.2` Options file (`.vipgoci_options`) Options file enabled: `true` Configurable options: `skip-execution` `skip-draft-prs` `lint-modified-files-only` `phpcs` `phpcs-severity` `phpcs-sniffs-include` `phpcs-sniffs-exclude` `report-no-issues-found` `review-comments-sort` `review-comments-include-severity` `post-generic-pr-support-comments` `review-comments-sort` `scan-details-msg-include` `svg-checks` `autoapprove` `autoapprove-php-nonfunctional-changes` `hashes-api` Options altered: `phpcs-severity`set to`1` `phpcs-sniffs-include`set to`Generic.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode` `phpcs-sniffs-exclude`set to`WordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax` `skip-draft-prs`set to	PHP lint options PHP lint files enabled: `true` Lint modified files only: `true` Directories not PHP linted: None SVG configuration SVG scanning enabled: `true` Auto-approval configuration Auto-approvals enabled: `true` Non-functional changes auto-approved: `true` Auto-approval DB enabled: `true` Auto-approved file-types: `css` `csv` `eot` `gif` `gz` `ico` `ini` `jpeg` `jpg` `json` `less` `map` `md` `mdown` `mo` `mp4` `otf` `pcss` `pdf` `po` `pot` `png` `sass` `scss` `styl` `ttf` `txt` `woff` `woff2` `yml`	PHPCS configuration PHPCS scanning enabled: `true` PHPCS severity level: `1` Standard(s) used: `PHPCompatibility` `PHPCompatibilityParagonieRandomCompat` `PHPCompatibilityParagonieSodiumCompat` `VariableAnalysis` `WordPress` Runtime set: `testVersion 8.1-` Custom sniffs included: `Generic.PHP.DisallowShortOpenTag` `Squiz.PHP.CommentedOutCode` Custom sniffs excluded: `WordPress.Security.EscapeOutput` `WordPress.PHP.DevelopmentFunctions` `WordPress.WP.AlternativeFunctions` `WordPress.PHP.DiscouragedPHPFunctions` `WordPress.Files.FileName` `Squiz.Commenting.FileComment` `Generic.PHP.Syntax` Directories not PHPCS scanned: `tests/unit`

tests/integration/StatisticsRuntimeMeasureShellExecWithRetryTest.php

Dismissing review as all inline comments are obsolete by now

wpcomvip-vipgoci-bot

phpcs scanning turned up:

🚫 6 errors

This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

Scan run detail

Software versions vip-go-ci version: `1.2.0` PHP runtime version for vip-go-ci: `8.1.3` PHP runtime version for PHP linting: `8.1.3` PHP runtime version for PHPCS: `7.4.28` PHPCS version: `3.6.2` Options file (`.vipgoci_options`) Options file enabled: `true` Configurable options: `skip-execution` `skip-draft-prs` `lint-modified-files-only` `phpcs` `phpcs-severity` `phpcs-sniffs-include` `phpcs-sniffs-exclude` `report-no-issues-found` `review-comments-sort` `review-comments-include-severity` `post-generic-pr-support-comments` `review-comments-sort` `scan-details-msg-include` `svg-checks` `autoapprove` `autoapprove-php-nonfunctional-changes` `hashes-api` Options altered: `phpcs-severity`set to`1` `phpcs-sniffs-include`set to`Generic.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode` `phpcs-sniffs-exclude`set to`WordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax` `skip-draft-prs`set to	PHP lint options PHP lint files enabled: `true` Lint modified files only: `true` Directories not PHP linted: None SVG configuration SVG scanning enabled: `true` Auto-approval configuration Auto-approvals enabled: `true` Non-functional changes auto-approved: `true` Auto-approval DB enabled: `true` Auto-approved file-types: `css` `csv` `eot` `gif` `gz` `ico` `ini` `jpeg` `jpg` `json` `less` `map` `md` `mdown` `mo` `mp4` `otf` `pcss` `pdf` `po` `pot` `png` `sass` `scss` `styl` `ttf` `txt` `woff` `woff2` `yml`	PHPCS configuration PHPCS scanning enabled: `true` PHPCS severity level: `1` Standard(s) used: `PHPCompatibility` `PHPCompatibilityParagonieRandomCompat` `PHPCompatibilityParagonieSodiumCompat` `VariableAnalysis` `WordPress` Runtime set: `testVersion 8.1-` Custom sniffs included: `Generic.PHP.DisallowShortOpenTag` `Squiz.PHP.CommentedOutCode` Custom sniffs excluded: `WordPress.Security.EscapeOutput` `WordPress.PHP.DevelopmentFunctions` `WordPress.WP.AlternativeFunctions` `WordPress.PHP.DiscouragedPHPFunctions` `WordPress.Files.FileName` `Squiz.Commenting.FileComment` `Generic.PHP.Syntax` Directories not PHPCS scanned: `tests/unit`

file-validation.php

git-repo.php

Dismissing review as all inline comments are obsolete by now

wpcomvip-vipgoci-bot · 2022-03-01T16:28:47Z

No issues were found to report when scanning latest commit (commit-ID: fac0361)

This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

Scan run detail

Software versions vip-go-ci version: `1.2.0` PHP runtime version for vip-go-ci: `8.1.3` PHP runtime version for PHP linting: `8.1.3` PHP runtime version for PHPCS: `7.4.28` PHPCS version: `3.6.2` Options file (`.vipgoci_options`) Options file enabled: `true` Configurable options: `skip-execution` `skip-draft-prs` `lint-modified-files-only` `phpcs` `phpcs-severity` `phpcs-sniffs-include` `phpcs-sniffs-exclude` `report-no-issues-found` `review-comments-sort` `review-comments-include-severity` `post-generic-pr-support-comments` `review-comments-sort` `scan-details-msg-include` `svg-checks` `autoapprove` `autoapprove-php-nonfunctional-changes` `hashes-api` Options altered: `phpcs-severity`set to`1` `phpcs-sniffs-include`set to`Generic.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode` `phpcs-sniffs-exclude`set to`WordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax` `skip-draft-prs`set to	PHP lint options PHP lint files enabled: `true` Lint modified files only: `true` Directories not PHP linted: None SVG configuration SVG scanning enabled: `true` Auto-approval configuration Auto-approvals enabled: `true` Non-functional changes auto-approved: `true` Auto-approval DB enabled: `true` Auto-approved file-types: `css` `csv` `eot` `gif` `gz` `ico` `ini` `jpeg` `jpg` `json` `less` `map` `md` `mdown` `mo` `mp4` `otf` `pcss` `pdf` `po` `pot` `png` `sass` `scss` `styl` `ttf` `txt` `woff` `woff2` `yml`	PHPCS configuration PHPCS scanning enabled: `true` PHPCS severity level: `1` Standard(s) used: `PHPCompatibility` `PHPCompatibilityParagonieRandomCompat` `PHPCompatibilityParagonieSodiumCompat` `VariableAnalysis` `WordPress` Runtime set: `testVersion 8.1-` Custom sniffs included: `Generic.PHP.DisallowShortOpenTag` `Squiz.PHP.CommentedOutCode` Custom sniffs excluded: `WordPress.Security.EscapeOutput` `WordPress.PHP.DevelopmentFunctions` `WordPress.WP.AlternativeFunctions` `WordPress.PHP.DiscouragedPHPFunctions` `WordPress.Files.FileName` `Squiz.Commenting.FileComment` `Generic.PHP.Syntax` Directories not PHPCS scanned: `tests/unit`

gudmdharalds added 9 commits February 28, 2022 16:05

Use vipgoci_runtime_measure()

e34f5fd

Use vipgoci_runtime_measure()

054ede1

Use vipgoci_runtime_measure()

d21687e

Rename vipgoci_runtime_measure_shell_exec() to vipgoci_runtime_measur…

f7e0f96

…e_shell_exec_with_retry()

Add 'helper-scripts' directory to list of exceptions.

07d5532

Rename test to fit new pattern.

7025d75

Add script that fails predictably.

f36ba75

Rename test file, add test for retries.

8440410

Extend vipgoci_runtime_measure_shell_exec() with retry capabilities.

6a5fdde

gudmdharalds added the [Type] Enhancement label Feb 28, 2022

gudmdharalds self-assigned this Feb 28, 2022

gudmdharalds added this to the 1.2.1 milestone Feb 28, 2022

Ensure script does not display errors.

87a4416

wpcomvip-vipgoci-bot previously requested changes Feb 28, 2022

View reviewed changes

tests/integration/helper-scripts/cli-predictably-fails.php Outdated Show resolved Hide resolved

tests/integration/helper-scripts/cli-predictably-fails.php Outdated Show resolved Hide resolved

tests/integration/helper-scripts/cli-predictably-fails.php Outdated Show resolved Hide resolved

gudmdharalds added 2 commits February 28, 2022 20:11

Add phpcs:ignore

47b5b7c

Update comment

505740f

gudmdharalds mentioned this pull request Feb 28, 2022

Use vipgoci_runtime_measure_shell_exec() where possible #155

Closed

gudmdharalds added 2 commits February 28, 2022 21:37

Adding more logging, restructuring logging.

d30c409

Suppress output, refine test

f24932e

wpcomvip-vipgoci-bot previously requested changes Feb 28, 2022

View reviewed changes

tests/integration/StatisticsRuntimeMeasureShellExecWithRetryTest.php Outdated Show resolved Hide resolved

tests/integration/StatisticsRuntimeMeasureShellExecWithRetryTest.php Outdated Show resolved Hide resolved

Fix whitespacing.

1a706d0

gudmdharalds added 6 commits February 28, 2022 22:41

Add comment. New assert.

604f308

Check output from SVG scanning.

cc6c738

Check output of running PHP interpreter.

2ea45d4

Check output of running PHPCS.

67e5d1d

Check output of running git.

778b650

Check output from running utility, refine logging.

58e2401

wpcomvip-vipgoci-bot previously requested changes Mar 1, 2022

View reviewed changes

Fixing whitespacing, adding comma.

83916e0

gudmdharalds added 3 commits March 1, 2022 16:09

Update comments, fix spelling.

b578c84

Replacing $return with $output.

9a20a2e

Updating comment, breaking up long line, adding assertation.

fac0361

gudmdharalds merged commit 209dc4c into main Mar 1, 2022

gudmdharalds deleted the add-exec-retry branch March 1, 2022 16:36

gudmdharalds added the [Pri] Normal label Mar 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend vipgoci_runtime_measure_shell_exec() with retry capabilities, and rename function #253

Extend vipgoci_runtime_measure_shell_exec() with retry capabilities, and rename function #253

gudmdharalds commented Feb 28, 2022 •

edited

Loading

wpcomvip-vipgoci-bot left a comment

Software versions

Options file (`.vipgoci_options`)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

wpcomvip-vipgoci-bot left a comment

Software versions

Options file (`.vipgoci_options`)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

wpcomvip-vipgoci-bot left a comment

Software versions

Options file (`.vipgoci_options`)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

wpcomvip-vipgoci-bot commented Mar 1, 2022

Software versions

Options file (`.vipgoci_options`)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

Extend vipgoci_runtime_measure_shell_exec() with retry capabilities, and rename function #253

Extend vipgoci_runtime_measure_shell_exec() with retry capabilities, and rename function #253

Conversation

gudmdharalds commented Feb 28, 2022 • edited Loading

wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

Software versions

Options file (.vipgoci_options)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

Software versions

Options file (.vipgoci_options)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

Software versions

Options file (.vipgoci_options)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

wpcomvip-vipgoci-bot commented Mar 1, 2022

Software versions

Options file (.vipgoci_options)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

gudmdharalds commented Feb 28, 2022 •

edited

Loading

Options file (`.vipgoci_options`)

Options file (`.vipgoci_options`)

Options file (`.vipgoci_options`)

Options file (`.vipgoci_options`)