Fix bot feedback message for limit of lines exceeded #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gudmdharalds
requested changes
Aug 30, 2021
ariskataoka
force-pushed
the
hotfix/line-limit-feedback-1-0-9
branch
from
9b00723 to
dd5f1ad
Compare
When the option skip-large-files-limit was defined, the bot was continuing to use the default limit of lines value. This PR fixes it.
ariskataoka
force-pushed
the
hotfix/line-limit-feedback-1-0-9
branch
from
dd5f1ad to
6e1e914
Compare
gudmdharalds
approved these changes
Sep 1, 2021
ariskataoka
added a commit
that referenced
this pull request
Sep 8, 2021
ariskataoka
added a commit
that referenced
this pull request
Oct 22, 2021
ariskataoka
added a commit
that referenced
this pull request
Nov 10, 2021
* Changelog for version 1.0.9 * Adding version 1.0.9 * Add #204 to the 1.0.9 changelog * Add #209 to the 1.0.9 changelog * Add #217 to the 1.0.9 changelog * Remove #205 changelog It's been postponed and won't be part of the 1.0.9 version. * Add #208 to the 1.0.9 changelog * Add #214 to the 1.0.9 changelog * Add release date to the change log Co-authored-by: Ariana Kataoka <[email protected]> Co-authored-by: Ariana Kataoka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the option skip-large-files-limit was defined, the bot was
continuing to use the default limit of lines value.
This PR fixes it.
TODO: