Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: install docker-compose #1751

Merged
merged 4 commits into from
Apr 2, 2024
Merged

ci: install docker-compose #1751

merged 4 commits into from
Apr 2, 2024

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented Apr 2, 2024

Description

Ref: actions/runner-images#9557

The 20240401.4.0 version of ubuntu-latest does not have docker-compose anymore.

See https://github.com/Automattic/vip-cli/actions/runs/8523736793/job/23346996749?pr=1739#step:6:11

Pull request checklist

New release checklist

Steps to Test

E2E tests should pass.

Example:

  1. Check out PR.
  2. Run npm run build
  3. Run ./dist/bin/vip-cookies.js nom
  4. Verify cookies are delicious.

@sjinks sjinks self-assigned this Apr 2, 2024
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@sjinks
Copy link
Member Author

sjinks commented Apr 2, 2024

Need #1752 to fix broken tests.

test: fix E2E tests for composer v2
Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sjinks sjinks requested a review from rinatkhaziev April 2, 2024 14:23
@sjinks sjinks merged commit c37d32e into trunk Apr 2, 2024
17 checks passed
@sjinks sjinks deleted the install/compose branch April 2, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants