Block canvas: remove unneeded CSS #6752
Conversation
| font-size: var(--wp--preset--font-size--small); | ||
| text-align: center; |
There was a problem hiding this comment.
It looks like these lines are still needed, but I recently opened a GB PR to address this: WordPress/gutenberg#46172 (I meant to look at this a while ago and this reminded me!)
There was a problem hiding this comment.
Thanks for following up — can we proceed with removing these or do you think some of the styles above are still needed?
There was a problem hiding this comment.
I guess it depends on how opinionated Block Canvas should be. I quite like the default styles of this caption being a smaller font size and centered, but perhaps we should remove these styles so we're relying on the defaults Core provides?
We could also use the caption element in theme.json to at least apply the small font size, rather than using CSS here.
| .wp-block-table thead { | ||
| border-bottom: 3px solid; | ||
| } | ||
| .wp-block-table tfoot { | ||
| border-top: 3px solid; |
There was a problem hiding this comment.
I think these are still needed too.
There was a problem hiding this comment.
We can remove these lines now as Core includes them in the default styles: WordPress/gutenberg#46567.
We should probably wait for GB 14.9 to be released before merging this.
Changes proposed in this Pull Request:
This PR removes some CSS that has since been added to Gutenberg (PR 45069)
Related issue(s):