Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appearance tools to all Varia themes #6428

Merged
merged 3 commits into from
Sep 1, 2022

Conversation

pbking
Copy link
Contributor

@pbking pbking commented Aug 22, 2022

Changes proposed in this Pull Request:

Flip the switch on appearance tools now that that can be done via theme_supports.

This effects all Varia and child themes.
alves
balasana
barnsbury
brompton
coutoire
dalston
exford
hever
leven
mayland
maywood
morden
redhill
rivington
rockfield
shawburn
stow
stratford

Before:
image

After:

image

Partially completes: #6411
Requires Gutenberg 14.0 to ship

@pbking pbking requested a review from a team August 22, 2022 20:34
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Robertght
Copy link

@pbking to be sure, these new options will be available only on the Group block, correct?
Also, is there a quick list I can check with the new options the themes will have?

@pbking
Copy link
Contributor Author

pbking commented Aug 26, 2022

No, this will effect any block that supports the settings outlined in the theme.json appearance tools. I just used the group block as an example. Offhand I'm not certain which blocks it covers.

https://github.com/WordPress/gutenberg/blob/trunk/docs/reference-guides/theme-json-reference/theme-json-living.md#appearancetools

@mtias
Copy link
Member

mtias commented Sep 1, 2022

Is this good to go?

@pbking
Copy link
Contributor Author

pbking commented Sep 1, 2022

I spot checked these on wpcom and they are all behaving as expected. I'm gonna ship this now.

@pbking pbking merged commit caa5ae2 into trunk Sep 1, 2022
@pbking pbking deleted the enhance/varia/appearance-tools branch September 1, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants