Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Club: adding styles for pullquote block #6388

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Conversation

matiasbenedetto
Copy link
Member

Changes proposed in this Pull Request:

Club: adding styles for pullquote block

Before After
image image

Related issue(s):

Fixes: #6379

@matiasbenedetto
Copy link
Member Author

Quick note. The Gutenberg pullquote block has a few problem when using text alignment left or right. This problem has a potential fix waiting for review: WordPress/gutenberg#43188

club/theme.json Outdated Show resolved Hide resolved
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, looks like it matches the mock!

I agree with @jffng about the line-height, I think this should be 1.3.

@matiasbenedetto matiasbenedetto merged commit 7da776e into trunk Aug 16, 2022
@matiasbenedetto matiasbenedetto deleted the club/pullquote branch August 16, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Club: Quote blocks improvements
3 participants