Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stewart: Move link and hover settings to theme.json #6121

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

scruffian
Copy link
Member

@scruffian scruffian commented Jun 23, 2022

Changes proposed in this Pull Request:

This moves link color and link hover color definitions from CSS to theme.json.
Does the same thing for textDecoration.

Related issue(s):

@getdave
Copy link
Contributor

getdave commented Jun 23, 2022

Requires WordPress/gutenberg#41786

@scruffian scruffian changed the title Stewart: Move link color and hover color to theme.json Stewart: Move link and hover settings to theme.json Jun 23, 2022
Copy link
Member

@matiasbenedetto matiasbenedetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matiasbenedetto
Copy link
Member

Since this was released with hover states in CSS and that feature is not in WordPress core yet, maybe we need to hold until that feature is in core to merge this. Moving to "approved but not mergeable"

@pbking pbking added this to the WordPress Core 6.1 milestone Jul 22, 2022
@madhusudhand madhusudhand merged commit 8458a1c into trunk Nov 7, 2022
@madhusudhand madhusudhand deleted the update/stewart-link-hover branch November 7, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants