Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockbase: reduces specificity for search block selectors #4376

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

MaggieCabrera
Copy link
Contributor

@MaggieCabrera MaggieCabrera commented Aug 10, 2021

Changes proposed in this Pull Request:

This is a follow-up to WordPress/gutenberg#33961 After that's merged we can actually remove the extra specificity that was needed for styles to persist on the editor. To test this check that the search block looks the same with and without this PR.

Test this with the mentioned PR active on your site, I'm waiting on tests to pass to merge it.

@MaggieCabrera MaggieCabrera self-assigned this Aug 10, 2021
@MaggieCabrera MaggieCabrera requested a review from a team August 10, 2021 08:19
Copy link
Member

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaggieCabrera MaggieCabrera merged commit 373f406 into trunk Aug 10, 2021
@MaggieCabrera MaggieCabrera deleted the blockbse-fix-search-block-specificity branch August 10, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants