Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libre 2: Remove editor styles #3305

Merged
merged 4 commits into from
Feb 22, 2021
Merged

Libre 2: Remove editor styles #3305

merged 4 commits into from
Feb 22, 2021

Conversation

scruffian
Copy link
Member

Changes proposed in this Pull Request:

Removes editor styles from Libre 2, and just loads regular styles into the editor.

Related issue(s):

Part of #3280

@scruffian scruffian requested a review from a team February 18, 2021 12:43
@scruffian scruffian self-assigned this Feb 18, 2021
@MaggieCabrera
Copy link
Contributor

Quote blocks look much better now than they did without this change but they are still loading some extra styles on the editor that are different from the frontend. They come from gutenberg/build/block-library/theme.css and the main issue is the border showing on the editor that is not showing up on the frontend:

Editor:

Screenshot 2021-02-19 at 10 38 46

Frontend:

Screenshot 2021-02-19 at 10 38 52

@MaggieCabrera
Copy link
Contributor

The latest comments block is miss aligned on the editor:

Screenshot 2021-02-19 at 10 44 57

@MaggieCabrera
Copy link
Contributor

The pullquote block is showing similar borders on the editor too:

Screenshot 2021-02-19 at 10 48 04

@MaggieCabrera
Copy link
Contributor

The gallery blocks are misaligned and the captions are a bit broken on the editor:
Screenshot 2021-02-19 at 10 49 44

@scruffian scruffian force-pushed the remove/libre-2-editor-styles branch from 47e84d5 to 2d0273b Compare February 19, 2021 10:03
@scruffian
Copy link
Member Author

I added some fixes to override the settings coming from theme.css. This is still not ideal and the front and back ends don't match up perfectly, but maybe it's good enough for now...

MaggieCabrera
MaggieCabrera approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks so much better now than it did before the PR. Great job @scruffian. I say ⛵

@scruffian scruffian merged commit f45441b into trunk Feb 22, 2021
@scruffian scruffian deleted the remove/libre-2-editor-styles branch February 22, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaggieCabrera MaggieCabrera MaggieCabrera approved these changes

Assignees

@scruffian scruffian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scruffian @MaggieCabrera