-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Penscratch: Update editor styles #3285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as #3284, works locally but cannot verify on wpcom.
I updated this to:
|
0912a97
to
8efa4c4
Compare
I took a different approach with this. I have removed almost all editor styles, and just kept one for the body content. This meant that the reset was leaking into the editor and breaking buttons. I have removed the reset from the main stylesheet and queued it separately in the front end. |
.editor-default-block-appender textarea.editor-default-block-appender__content { | ||
font-family: "Roboto Slab", Georgia, Times, serif; | ||
body { | ||
background: #fff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's kind of a shame that this line is needed just to override the default background color, otherwise we could get rid of this file entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add a Gutenberg class to the CSS that targets the site content, but I don't want to start mixing editor CSS into the main file.
… white, and reference the files locally
8ec2f6f
to
7868bf3
Compare
Thanks for testing. I moved the form CSS into a separate file, which fixes the problems you found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to ⛵
Changes proposed in this Pull Request:
Updates editor styles so that they work with Gutenberg 9.9.
It would be better to just use the normal theme styles but the classes in Gutenberg don't match the front end :(
Related issue(s):
Part of #3280