Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independent Publisher: Add theme styles to the editor so that fonts match #3283

Closed
wants to merge 5 commits into from

Conversation

scruffian
Copy link
Member

Changes proposed in this Pull Request:

This adds the theme styles to the editor so that the frontend and the editor match. Ideally we wouldn't need editor styles at all, but the post title requires them, and maybe other blocks do to...

Related issue(s):

Part of #3280

@scruffian scruffian requested a review from a team February 16, 2021 11:01
@scruffian scruffian self-assigned this Feb 16, 2021
Copy link
Contributor

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue of the incorrect fonts loading in the editor.

@jffng
Copy link
Contributor

jffng commented Feb 16, 2021

Should the minor version number be bumped?

@scruffian
Copy link
Member Author

Changed to local file references and bumped the version number.

@scruffian
Copy link
Member Author

I also removed the .edit-post-visual-editor selector from editor-blocks.css. When this file is added as an editor style then the .editor-styles-wrapper prefix is added, so .edit-post-visual-editor won't work. I also renamed .editor-block-list__block to .block-editor-block-list__block since the class has changed names in Gutenberg.

@scruffian scruffian force-pushed the update/independent-publisher-2-editor-styles branch from 43a5bcf to fcc16d6 Compare February 19, 2021 09:02
@scruffian
Copy link
Member Author

I updated the approach here to remove as many editor styles as possible. This is ready for another review.

@jffng
Copy link
Contributor

jffng commented Feb 19, 2021

This is being affected in the same way that Penscratch was, where some styles are leaking into the editor UI:

Screen Shot 2021-02-19 at 9 12 20 AM

@scruffian scruffian force-pushed the update/independent-publisher-2-editor-styles branch from 990ac59 to 2e99190 Compare February 22, 2021 11:24
@scruffian scruffian closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants