Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varia themes: fix cover block + layout grid bug #3004

Closed
wants to merge 1 commit into from

Conversation

jffng
Copy link
Contributor

@jffng jffng commented Jan 11, 2021

This PR addresses #2976.

To describe what's going on in more detail: 

  • The cover block's default CSS contains height: 100%;
  • When you place a cover block inside a layout grid column, the cover takes up 100% of the calculated height of the layout grid column, pushing whatever else inside that same column beyond the height the column takes up in the document flow. This is why the footer credit appears in the middle as reported in 2976.
  • It happens to be that the Doyle layout uses this pattern, but any theme that implements the pattern would experience this issue.

This PR targets all direct descendants of layout grid columns to set their height: auto. It feels like a bandaid, and I'm not attached to this solution but wanted to put it out there to get a fix in place.

To test

  • Follow the steps to recreate the pattern described in Alves: Footer Credit Migrates To The Middle Of Page #2976. You can use any varia theme on a free plan.
  • Verify that any elements that are placed after the group block appear to overlap the layout grid
  • Apply this patch (D55158), and verify that the issue is resolved

@jffng jffng requested a review from a team January 11, 2021 17:39
@jffng jffng self-assigned this Jan 11, 2021
@jffng jffng added the [Type] Bug Something isn't working label Jan 11, 2021
@jffng jffng linked an issue Jan 11, 2021 that may be closed by this pull request
@scruffian
Copy link
Member

Do you think we should make this fix in the block itself?

@jffng
Copy link
Contributor Author

jffng commented Jan 11, 2021

I think so. I will propose it.

@jffng
Copy link
Contributor Author

jffng commented Jan 11, 2021

@jffng
Copy link
Contributor Author

jffng commented Jan 12, 2021

The above PR has been merged and fixes this issue.

@jffng jffng closed this Jan 12, 2021
@scruffian scruffian deleted the fix/layout-grid-height-bug branch January 12, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alves: Footer Credit Migrates To The Middle Of Page
2 participants