Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seedlet blocks: update template parts to full width #2203

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

vindl
Copy link
Member

@vindl vindl commented Jul 1, 2020

Changes proposed in this Pull Request:

Updates the Seedlet block template parts and post content in templates to full width. Previously these were constrained to standard width which prevented us from recreating full page layouts, causing issues like this one Automattic/wp-calypso#43640.

@ockham added this capability in core in WordPress/gutenberg#23488 so now we can update the theme to use that.

Testing instructions

  1. Run latest version of Gutenberg master locally.
  2. Map this branch of Seedlet blocks theme to your local install.
  3. Delete any existing templates or template parts that you might have saved.
  4. Make sure that demo templates experiment is turned off.
  5. Open the site editor.
  6. Verify that post content and template parts have full width by default.

Screenshot 2020-07-01 at 14 08 55

@vindl vindl self-assigned this Jul 1, 2020
@vindl vindl requested review from kjellr, ianstewart, ockham, jeyip, Addison-Stavlo, noahtallen and a team and removed request for ockham, jeyip, noahtallen and Addison-Stavlo July 1, 2020 12:11
Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 That's an excellent improvement, thank you! I'll deploy this over to WP.com.

@kjellr kjellr merged commit aaa2d22 into master Jul 1, 2020
@kjellr kjellr deleted the update/seedlet-blocks-templates-width branch July 1, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants