Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo 1.0.0.5: work made based on demo1.0.0.4 feedback #68

Merged
merged 21 commits into from
Sep 23, 2019

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Aug 29, 2019

This PR implements all of the details explained in #61. To make a short list:

  • Swipe from bottom to discover emoji picker on the composing screen.
  • Only start recording video after vibration indication ends (to avoid capturing noise on video)
  • always show navigation bar
  • made the Delete view behind added views, and added transparency tweak to hint the view is about to be removed if you lift your finger.

Things not covered in this PR, but tracked elsewhere

@mzorz mzorz mentioned this pull request Aug 31, 2019
17 tasks
@mzorz
Copy link
Contributor Author

mzorz commented Sep 3, 2019

==== produced build, should not receive further commits

@aforcier aforcier changed the base branch from issue/13-edit-screen-controls-save-delete-drag to issue/13-edit-screen September 20, 2019 09:03
@aforcier aforcier marked this pull request as ready for review September 23, 2019 07:32
@aforcier aforcier self-assigned this Sep 23, 2019
@aforcier aforcier added this to the Demo 1: Basic Creation milestone Sep 23, 2019
@aforcier
Copy link
Collaborator

:shipit: !

@aforcier aforcier merged commit 454a8b2 into issue/13-edit-screen Sep 23, 2019
@aforcier aforcier deleted the issue/61-demo1.0.0.4-feedback branch September 23, 2019 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants