New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CameraX update (part3) using setTargetResolution with normalized values on VideoCapture #643

Draft

mzorz wants to merge 1 commit into try/camerax-update-1.0.0-rc-02 from try/camerax-update-1.0.0-rc-02-video-res

Contributor

mzorz commented Feb 22, 2021

This PR explores using a combination of:

target aspect ratio for Preview & ImageCapture use cases
target resolution for the VideoCapture use case instead
passing a normalized target resolution to it, which is the same normalized resolution being used to generate the resulting stories video slide in mp4composer

In general, it seemed to get us better results on the tested handsets (see #638), but leaving this exploration as an experiment only for now


          using setTargetResolution with normalized values on VideoCapture use …

…case

peril-automattic bot commented Feb 22, 2021

You can test the changes on this Pull Request by downloading the APK here.

mzorz added the CameraX label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CameraX