Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show delete button when long pressing a slide #602

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

aforcier
Copy link
Collaborator

@aforcier aforcier commented Nov 5, 2020

Closes #583. In addition to tapping the current slide to show the delete button, this PR also adds long press behavior. Long pressing any slide (no matter which slide you're currently on) will switch to that slide and show the delete button.

This build has been tested and 👍 'd by @megsfulton . She had some suggested improvements which we can make in the future - recorded those in #599 .

To test:

  1. Create a story with multiple slides
  2. Verify that long pressing the current slide shows the delete button and you can delete the slide
  3. Verify that long pressing a slide you're not on switches to that slide and shows the delete button (and you can delete the slide)
  4. Verify that long pressing the active slide again after step 2 or 3 hides the delete button
  5. Verify that dragging to swap slides still works
  6. Check that when slides are swapped, the delete button is hidden (since the long press action has been completed)

@aforcier aforcier requested a review from mzorz November 5, 2020 03:26
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected, great job @aforcier !

LGTM :shipit:

@mzorz mzorz merged commit df51ba7 into develop Nov 5, 2020
@mzorz mzorz deleted the issue/583-long-press-delete-slide branch November 5, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trash icon discoverability: discussion
2 participants