Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hideCancel flag to FrameSaveErrorDialog #601

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Nov 4, 2020

In some situations, we need an okListener but we don't want the cancel button to appear on the dialog. Added a flag to indicate so in this PR.

To test: see related WPAndroid PR with a specific use case wordpress-mobile/WordPress-Android#13287

Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@mzorz mzorz merged commit 8093946 into develop Nov 4, 2020
@mzorz mzorz deleted the fix/update-error-dialog branch November 4, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants