Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only try adding emojiPickerFragment when it's not added and not visible #456

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Only try adding emojiPickerFragment when it's not added and not visible #456

merged 1 commit into from
Jul 22, 2020

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Jul 22, 2020

Fixes #455

To test:

  1. open the demo app
  2. capture an image
  3. tap on the stickers icon like crazy until it appears (it's easier to reproduce on lower end handsets, for example the Samsung J2 takes a noticeable length of time to show the bottom sheet emoji picker)
  4. observe no crash

See video of the Samsung J2 here https://cloudup.com/cfittOshxwa

@mzorz mzorz requested a review from jd-alexander July 22, 2020 13:38
jd-alexander
jd-alexander approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes @mzorz Tested and it works as expected! 👍

@jd-alexander jd-alexander merged commit 51c112c into feature/wp-stories/alpha2 Jul 22, 2020
@jd-alexander jd-alexander deleted the issue/455-crash-emoji-fragment branch July 22, 2020 21:28
@aforcier aforcier mentioned this pull request Jul 23, 2020
Merged
@mzorz mzorz mentioned this pull request Jul 23, 2020
Closed
@mzorz mzorz mentioned this pull request Aug 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd-alexander jd-alexander jd-alexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzorz @jd-alexander