Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in project #1142

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Fix warnings in project #1142

merged 4 commits into from
Apr 17, 2024

Conversation

charliescheer
Copy link
Contributor

Fix

I noticed a few warnings had crept into SN Mac (most of which were created by me recently.... oops) this PR updates the project to remove all warnings.

Test

Not much to test.

  • confirm app builds
  • confirm you can drag and drop tags
  • confirm on login if you switch from signup to login all of the views appear correctly.

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

If the changes should not be included in release notes, add a statement to this section. For example:

These changes do not require release notes.

@charliescheer charliescheer added the debt Technical debt. label Apr 16, 2024
@charliescheer charliescheer added this to the Future milestone Apr 16, 2024
@charliescheer charliescheer self-assigned this Apr 16, 2024
Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Verified the app builds
✅ Verified that Tags Drag+Drop still works
✅ Verified you can log out / log in

Thank you Charlie!! :shipit:

@charliescheer charliescheer merged commit b2232e9 into trunk Apr 17, 2024
8 of 11 checks passed
@charliescheer charliescheer deleted the charlie/fix-warnings branch April 17, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants