Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: TextKit 2 mk1 #1689

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Draft

WIP: TextKit 2 mk1 #1689

wants to merge 3 commits into from

Conversation

charliescheer
Copy link
Contributor

Fix

This PR is the first step in implementing Textkit 2 into Simplenote. Why do we need this? Well primarily it is to keep up with the next paradigms in apple development. Also with the addition of Textkit 2 we should get all of the new Apple intelligence features for free. Lastly, by removing the reliance on glyphs and glyph ranges in TextKit 2, we should be able to fix many of the out of range crashes that we sometimes see with multi bit character languages.

Here I have taken the first steps. I have:

  • created the TextKit 2 layout properties if the device can run them
  • layout the text with the same appearance as text in TextKit 1
  • allow for tapping into and editing text without switching back to TextKit 1

Test

  1. Launch the app, open a note
  • Confirm that the text is styled correctly for SN
  • Confirm that if you tap into the text you are able to become first responder
  • Confirm that you can enter text
  • Confirm that you never see this warning in the console UITextView 0x10500fe00 is switching to TextKit 1 compatibility mode because its layoutManager was accessed

Review

(Required) Add instructions for reviewers. For example:

Only one developer and required to review these changes, but anyone can perform the review.

Release

(Required) Add a concise statement to RELEASE-NOTES.txt if the changes should be included in release notes. Include details about updating the notes in this section. For example:

RELEASE-NOTES.txt was updated in d3adb3ef with:

Added markdown support

If the changes should not be included in release notes, add a statement to this section. For example:

These changes do not require release notes.

@charliescheer charliescheer self-assigned this Dec 20, 2024
@charliescheer charliescheer added the [feature] editor Anything related to the editor. label Dec 20, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

Simplenote Prototype Build📲 You can test the changes from this Pull Request in Simplenote Prototype Build by scanning the QR code below to install the corresponding build.
App NameSimplenote Prototype Build Simplenote Prototype Build
Build Numberpr1689-f15e313-0193e66f-69ca-4bcc-a2aa-a5f571af5c4b
Version4.55
Bundle IDcom.codality.NotationalFlow.Alpha
Commitf15e313
App Center BuildSimplenote - Installable Builds #414
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[feature] editor Anything related to the editor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants