Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minimatch dependency error #542

Merged
merged 1 commit into from
Apr 19, 2017
Merged

Fix minimatch dependency error #542

merged 1 commit into from
Apr 19, 2017

Conversation

owcz
Copy link
Contributor

@owcz owcz commented Apr 9, 2017 •
edited
Loading

Resolves one of three dependency issues in #357

No errors thrown in my installation, but I don't have syncing set up, etc. and can use some outside testing

@owcz owcz mentioned this pull request Apr 9, 2017
Closed
@dmsnell dmsnell self-assigned this Apr 9, 2017
@dmsnell dmsnell requested a review from rodrigoi April 9, 2017 16:03
@dmsnell
Copy link
Member

dmsnell commented Apr 18, 2017

After this change I was able to build the OS X package but I'm having trouble with the others. @rodrigoi would you mind giving this a look-over to confirm that the update works well enough?

Thanks for the fix @owcz!

rodrigoi
rodrigoi approved these changes Apr 19, 2017
View reviewed changes
Copy link
Contributor

@rodrigoi rodrigoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I've tested the build process and the resulting builds and found no regressions.
Thanks @owcz !

@rodrigoi rodrigoi merged commit af22336 into Automattic:master Apr 19, 2017
@owcz owcz deleted the update-packages branch April 20, 2017 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigoi rodrigoi rodrigoi approved these changes

Assignees

@dmsnell dmsnell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owcz @dmsnell @rodrigoi