Improve note Action and Info focus management #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React Modal provides its own focus trap logic, so wrapping with `FocusTrap` is unnecessary.
In order for clipboard.js to function properly within a focus trap, we must set a `container` that is "reachable" from within the focus trap. https://clipboardjs.com/#advanced-usage
|
@sandymcfadden this PR represents what I found when investigating usage of clipboard.js within a focus trap. Please feel free to merge/cherrypick/modify/discard any of these changes as you see fit. |
sandymcfadden
approved these changes
Mar 10, 2021
sandymcfadden
pushed a commit
that referenced
this pull request
Mar 22, 2021
…still dark theme on note info, dark theme hover on note actions, remove icons from menubar remove publish tab from sharing dialog ignore clickoutside on the icon, remove unused icons still terrible but slowly getting less terrible switch position of preview and checklist icon make publish checkbox work checkbox styling lint adjust note info styles, cross icon, reference link titles menu item and order changes Add checkbox styles Switching from using react-clickoutside to focus-trap-react Changing clickable divs to buttons Fix linting error in css Switch from onClickOutside to focus-trap-react on the note info dialog Fix package-lock.json file Improve note Action and Info focus management (#2737) Remove redundant focus management within note Info. React Modal provides its own focus trap logic, so wrapping with FocusTrap is unnecessary. Support ClipboardButton within focus trap for note actions. In order for clipboard.js to function properly within a focus trap, we must set a container that is "reachable" from within the focus trap. Update styles for when history is disabled Update note info styles to match designs. Update border and boxshadow of note actions Updates to the note action styles Add loading state for publishing note Remove commented out no longer needed styles Fix css linting error Testing a throttle on the pin note action Removing the throttle added in the previous commit Update styles for note info dialog
sandymcfadden
pushed a commit
that referenced
this pull request
Apr 8, 2021
…still dark theme on note info, dark theme hover on note actions, remove icons from menubar remove publish tab from sharing dialog ignore clickoutside on the icon, remove unused icons still terrible but slowly getting less terrible switch position of preview and checklist icon make publish checkbox work checkbox styling lint adjust note info styles, cross icon, reference link titles menu item and order changes Add checkbox styles Switching from using react-clickoutside to focus-trap-react Changing clickable divs to buttons Fix linting error in css Switch from onClickOutside to focus-trap-react on the note info dialog Fix package-lock.json file Improve note Action and Info focus management (#2737) Remove redundant focus management within note Info. React Modal provides its own focus trap logic, so wrapping with FocusTrap is unnecessary. Support ClipboardButton within focus trap for note actions. In order for clipboard.js to function properly within a focus trap, we must set a container that is "reachable" from within the focus trap. Update styles for when history is disabled Update note info styles to match designs. Update border and boxshadow of note actions Updates to the note action styles Add loading state for publishing note Remove commented out no longer needed styles Fix css linting error Testing a throttle on the pin note action Removing the throttle added in the previous commit Update styles for note info dialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
FocusTrapis unnecessary.containerthat is "reachable" from within the focus trap.Test
Expected Outcome: Both internal and public links should be within clipboard
history.
Release
n/a