Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow RTL formatting in markdown mode #2339

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

belcherj
Copy link
Contributor

Fix

Fixes: #562

Allow RTL languages to be right aligned in markdown preview mode.

Before:

Screen Shot 2020-09-21 at 8 22 57 PM

After:

Screen Shot 2020-09-21 at 8 22 42 PM

Test

  1. Have several notes with markdown
  2. Does markdown look properly in preview mode

@belcherj belcherj requested a review from a team September 22, 2020 00:24
@belcherj belcherj self-assigned this Sep 22, 2020
Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tested fine in my test document with mixed-direction content in separate paragraphs but also inline. I don't understand the implications of unicode-bidi property but plaintext seems reasonable.

@belcherj belcherj merged commit 59fbc00 into develop Sep 22, 2020
@belcherj belcherj deleted the update/allow-rtl-format-in-markdown branch September 22, 2020 01:57
@belcherj
Copy link
Contributor Author

https://developer.mozilla.org/en-US/docs/Web/CSS/unicode-bidi

plaintext
This keyword makes the elements directionality calculated without considering its parent bidirectional state or the value of the direction property. The directionality is calculated using the P2 and P3 rules of the Unicode Bidirectional Algorithm.
This value allows the display of data that is already formatted using a tool following the Unicode Bidirectional Algorithm.

@codebykat codebykat added this to the 2.0.0 milestone Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview mode doesn't support RTL
3 participants