Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protection against insecure passwords #2088

Merged
merged 5 commits into from
May 18, 2020

Conversation

belcherj
Copy link
Contributor

@belcherj belcherj commented May 14, 2020

Fix

If the user has a password that does not meet the strength requirements we are now displaying an error message that they need to reset their password.

Test

  1. Have insecure password (less than 8 characters)
  2. In the electron app, try to login
  3. Observe you are redirected to the reset form with email pre-filled

Screen Shot 2020-05-15 at 2 27 41 PM

@codebykat codebykat force-pushed the add/insecure-password-protection branch from 5ef74f2 to 4e6a8de Compare May 15, 2020 10:12
@belcherj belcherj self-assigned this May 15, 2020
@belcherj belcherj requested a review from a team May 15, 2020 18:39
@belcherj belcherj marked this pull request as ready for review May 15, 2020 18:39
@codebykat codebykat merged commit abb89dc into develop May 18, 2020
@codebykat codebykat deleted the add/insecure-password-protection branch May 18, 2020 00:01
@codebykat codebykat added this to the 1.17 milestone May 18, 2020
@codebykat
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants