Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update password validation on signup #2087

Merged
merged 3 commits into from
May 17, 2020
Merged

Update password validation on signup #2087

merged 3 commits into from
May 17, 2020

Conversation

belcherj
Copy link
Contributor

@belcherj belcherj commented May 14, 2020 •
edited
Loading

Fix

Add password strength requirements to the signup form in electron.

Test

  1. Open electron
  2. Try to sign up with an insecure password
  3. Observe error

Screen Shot 2020-05-15 at 2 42 44 PM

@belcherj
Copy link
Contributor Author

SHould look at using the strings from Android: https://github.com/Automattic/simplenote-android/pull/998/files

@codebykat codebykat force-pushed the update/password-strength-on-signup branch from 5052c55 to 16b957e Compare May 15, 2020 09:59
@codebykat
Copy link
Member

I'd also like to clean up the form validation here to match GAE

@belcherj belcherj marked this pull request as ready for review May 15, 2020 18:43
@belcherj belcherj requested a review from a team May 15, 2020 18:44
@belcherj belcherj merged commit 7591c62 into develop May 17, 2020
@belcherj belcherj deleted the update/password-strength-on-signup branch May 17, 2020 18:08
@codebykat codebykat added this to the 1.17 milestone May 18, 2020
@codebykat
Copy link
Member

Automattic/Simplenote-United#60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@codebykat codebykat

@belcherj belcherj

Labels
None yet
Projects
None yet
Milestone
1.17
Development

Successfully merging this pull request may close these issues.
2 participants
@belcherj @codebykat