Merge release 1.16.0 into develop #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 1.16 release notes * Rename RELEASE-NOTES.txt to RELEASE-NOTES.md In #1576 we renamed `CHANGELOG.md` to `RELEASE-NOTES.txt` and in so doing we broke any integration which attempted to render the contents of the file as Markdown. The file continued to be written as a Markdown document but by renaming the extension we prevented any tools which rely on the extension to detect the type and so valuable tools like GitHub's diff viewer wouldn't show the contents of the file as they were written but instead as if they were plain text. In this patch we're renaming it back to a `.md` extension to reflect the reality of the file that it is indeed Markdown content. In so doing we're fixing the integrations that were broken in #1576. * typo fixes Co-authored-by: Dennis Snell <[email protected]>
#2041) * Hotkeys: Always allow using the Ctrl-T shortcut to jump between note/tags Previously we were only allowing a switch _from_ the note editor _to_ the tag editor, or _from_ the tag editor _to_ the note editor, but we really want to allow jumping between these fields any time, even if none is selected. With the work to improve keyboard shortcut usability this is more important since we're emphasizing keyboard navigation. In this patch we change the conditional from one that gates the behavior to one that uses the current focus to determine which to jump to. * Prevent the TagField from stealing focus when swapping to editor
* most of a fix for this by not overloading CLOSE_NOTE * default to true so we show the note list on first load on small screens * toggle back into the note list after next/prev * don't open note list on next/prev if it's not already open * change wording of note list key since it's a toggle now * Remove some unused code * Remove toggling behavior from note list * Separate the action of selecting a note from the action of opening it * Disable note-editing from list view and open note on Enter presses It was possible to edit the contents of a note in a small-screen view with the note list open. This was confusing because it wasn't obvious that the edits were applying. In this change the editor (with help of some ugly prop-drilling) disables itself while in a small-screen view while the note list is open. In order to ease the jump back to the note the Enter key now opens it. * review cleanup * Keep highlighted note in view in list view * Stop rendering editor when it's not visible Previously we were always rendering the editor. When very large or slow notes were in the list it made for abrupt pauses while scrolling through the list. In this change we stop rendering the editor altogether if only the list view is visible. This has removed all abrupt pauses when scrolling through the list view on the narrow-screen mode. * Remove workaround for disabling the editor while hidden Co-authored-by: Dennis Snell <[email protected]>
* Fix keyboard shortcut issues identified in release testing Resolves #2025 Resolves #2026 Changes: - restores "focus mode" hotkey to Ctrl + Shift + F - resets "focus search field" hotkey to Ctrl + F - rewords description of Ctrl + G - rewords "select previous/next" to "above/below" - disables browser default behavior on Ctrl + G - removes hotkey Ctrl + Backspace to prevent accidentally trashing note - inlines keyboard shortcut explainer to one column only for visual styling purposes * Stop beeping on ctrl + / * Make the delete-key behavior on macOS slightly more clear * Use cmd on web as well as desktop macOS * Web should always be ctrl even on macOS * add tooltip to Back, handle KeyL from note list * Move list-toggle keybinding up to make sure we always capture it * Stop passing up/down note selection hotkeys to parent app * Recompute note list heights when toggling note list Co-authored-by: Jonathan (JB) Belcher <[email protected]> Co-authored-by: Kat Hagan <[email protected]>
After deploying the release candidate to app.simplenote.com we noticed a surge in support requests for missing notes. Upon investigation we discovered that notes with `deleted: 0` were being excluded from the search results; this was due to a strict type comparison of the `deleted` property with the boolean `showTrash` flag. To resolve this issue we have coerced the `deleted` property to a boolean value when inserting a note into the index.
|
Noting that I read the code changes and they look correct to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.