Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use proper import path for state types in app layout #1923

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

dmsnell
Copy link
Member

@dmsnell dmsnell commented Feb 21, 2020

In #1895 we added an import to ./state that should have been
../state. This didn't break the app because the import only
affected the types.

In this patch we're fixing the import path.

Testing

This should have no impact on the final built code and therefore
no changes on the output.

In #1895 we added an import to `./state` that should have been
`../state`. This didn't break the app because the import only
affected the types.

In this patch we're fixing the import path.
@dmsnell dmsnell requested a review from a team February 21, 2020 02:28
Copy link
Contributor

@belcherj belcherj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@belcherj belcherj merged commit 480e543 into develop Feb 21, 2020
@belcherj belcherj deleted the fix/fix-type-path-import branch February 21, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants