Fix: Render unicode bullet as list in Markdown preview #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we have been failing to render bulleted-lists which use the Unicode `\u2022` "Bullet". The preview would fail to show the line as a new list item and therefore inline it and any successive list items into a single paragraph/item. Now we are replacing those bullets before rendering the Markdown so that it will render properly as any other bullet would.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we have been failing to render bulleted-lists which use the
Unicode
\u2022"Bullet". The preview would fail to show the line asa new list item and therefore inline it and any successive list items
into a single paragraph/item.
Now we are replacing those bullets before rendering the Markdown so
that it will render properly as any other bullet would.
Testing
Create a note with a Unicode bullet for the list items
In
developit will render inline with the previous item inside the Preview.In this branch it should appear as a proper rendered bullet.
