Include diff-match-patch surrogate fix v2 #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates `node-simperium` in order to incorportate the second fix in `diff-match-patch` for the successive surrogate issue. Specifically this fix includes a custom URI decoder to accept changes from the server which would otherwise crash the decoding thread (invalid Unicode characters URI-encoded as if they were - Python 2 encoding surrogate halves separately). This change should not have a noticable impact on the app and should only fix a few remaining cases where successive surrogate pairs could previously interrupt the syncing process.
belcherj
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
node-simperiumin order to incorportate the second fix indiff-match-patchfor the successive surrogate issue. Specificallythis fix includes a custom URI decoder to accept changes from the
server which would otherwise crash the decoding thread (invalid Unicode
characters URI-encoded as if they were - Python 2 encoding surrogate
halves separately).
This change should not have a noticable impact on the app and should
only fix a few remaining cases where successive surrogate pairs could
previously interrupt the syncing process.