Move list title to redux #1902
Merged
Move list title to redux #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
reviewed
Feb 12, 2020
dmsnell
reviewed
Feb 12, 2020
dmsnell
reviewed
Feb 12, 2020
There was a problem hiding this comment.
Nice update. I like how this pulls together the places that impact the placeholder. Mentioning the placeholder it earmarks some future work where maybe this should be less a string value and more a mode that gets translated (eventually) in render()
This might very well be a key part to understanding the role of trash and fit into state-bound URL paths.
Except for the optional-chaining which I didn't think was necessary you have my ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Move list title to redux. The list title is used as the placeholder for the search field.
Test