Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard shortcuts on Windows Chrome #1888

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Conversation

belcherj
Copy link
Contributor

@belcherj belcherj commented Feb 7, 2020

Fix

Fixes the ctrl + shift + j/k keyboard shortcut on Windows Chrome and Windows Electron.

Adds the same logic to other shortcuts to ensure bugs of the same sort don't pop up:

  • ctrl + shift + t - open tag list
  • ctrl + shift + n - open note list
  • ctrl + t - move between tag editor and note editor

Test

  1. In windows chrome
  2. Click a note in the note list
  3. Use ctrl + shift + j/k to navigate between notes
  4. Use ctrl + shift + up/down arrow keys to navigate between notes
  5. Use ctrl + shift + t to open close the tag list
  6. In OSX Electron make Simplenote small so only note list or note is visible
  7. Open a note
  8. Use ctrl + shift + n to go back to note list
  9. Open note
  10. Use ctrl + t to move back and forth between tag editor and note editor

Note:
ctrl + shift + n and ctrl + t do not work in many places do to Chrome not allowing us to override the built in keyboard shortcuts. https://bugs.chromium.org/p/chromium/issues/detail?id=33056

Release

  • Fixes ctrl + shift + j/k keyboard shortcut on Windows #1888

@belcherj belcherj requested a review from a team February 7, 2020 15:37
@belcherj belcherj self-assigned this Feb 7, 2020
@belcherj belcherj changed the title Fix note up/down shortcut on Windows Chrome Fix keyboard shortcuts on Windows Chrome Feb 7, 2020
lib/note-editor/index.tsx Outdated Show resolved Hide resolved
@belcherj belcherj force-pushed the fix/note-up-down-shortcut branch from 4a3d4ee to 255d105 Compare February 11, 2020 14:52
Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good changes. Let's test this in batch with a few more of your PRs that are getting merged today.

@belcherj belcherj merged commit c0a0901 into develop Feb 11, 2020
@belcherj belcherj deleted the fix/note-up-down-shortcut branch March 10, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants