Types: Add types to <EditableList /> component #1886
Conversation
| // Language and Platform | ||
| /////////////////////////////////////// | ||
|
|
||
| export type Without<T, U> = { [P in Exclude<keyof T, keyof U>]?: never }; |
There was a problem hiding this comment.
I feel like these need some explanation as to what they are.
There was a problem hiding this comment.
can do and will add. I feel like XOR should be in the language. it's here because the | is only really useful when we have a property on which to discriminate alternative types.
type Colors = { name: 'red', value: 0xff000 } | { name: 'green', value: 0x00ff00 };This fails if our types our different
type Size = { radius: number } | { width: number; height: number };It should be able to do this but it can't. When we don't have that property we have to rely on more advanced typing. In this case it's a mapped type called XOR which does exactly what | seems like it should do. Without is part of it and gets the difference of keys between them. Here I've used XOR because MouseEvent and TouchEvent don't have the discriminating property.
type Size = XOR<{radius: number}, {width: number; height: number}>We can keep adding to the types by nesting, unlike the convenient chaining of |
type Size = XOR<{radius: number}, XOR<{width: number; height: number}, {kg: number}>>
lib/editable-list/index.tsx
Outdated
| static propTypes = { | ||
| className: PropTypes.string, | ||
| editing: PropTypes.bool.isRequired, |
As we changed some code here, specifically around initializing instance variables, we need to be extra careful in testing to prevent regressions.
dmsnell
force-pushed
the
types/type-editable-list
branch
from
19190e3 to
ad6a836
Compare
|
Testing in batch with other PRs merging today. |
As we changed some code here, specifically around initializing instance
variables, we need to be extra careful in testing to prevent regressions.