Types: Add some more types to boot and some utils #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
added a commit
that referenced
this pull request
Feb 6, 2020
Discovered via TypeScript in #1884 Previously when authorizing an account which yields no `access_token` we have been attempting to reset the authorization state by dispatching `resetAuth`. Unfortunately we haven't been dispatching the function call but rather the function/action-creator itself leading to no actionable dispatch. In this patch we're fixing the call by calling `resetAuth()` which then passes a real action to the dispatcher. This should fix an unsurfaced but during invalid authentication flows.
belcherj
suggested changes
Feb 6, 2020
| @@ -66,6 +66,7 @@ | |||
| "@types/redux": "3.6.0", | |||
| "@types/redux-localstorage": "1.0.8", | |||
| "@types/rimraf": "2.0.3", | |||
| "@types/valid-url": "1.0.2", | |||
dmsnell
force-pushed
the
types/type-boot-and-sanitize-html
branch
from
89ef1e9 to
0f8843e
Compare
dmsnell
added a commit
that referenced
this pull request
Feb 10, 2020
Discovered via TypeScript in #1884 Previously when authorizing an account which yields no `access_token` we have been attempting to reset the authorization state by dispatching `resetAuth`. Unfortunately we haven't been dispatching the function call but rather the function/action-creator itself leading to no actionable dispatch. In this patch we're fixing the call by calling `resetAuth()` which then passes a real action to the dispatcher. This should fix an unsurfaced but during invalid authentication flows.
Only real change should be some optional-chaining. Discovered a but in `resetAuth` that needs to be fixed outside of this branch.
dmsnell
force-pushed
the
types/type-boot-and-sanitize-html
branch
from
0f8843e to
4faec62
Compare
|
Testing in batch with other PRs merging today. |
dmsnell
added a commit
that referenced
this pull request
Feb 11, 2020
Discovered via TypeScript in #1884 Previously when authorizing an account which yields no `access_token` we have been attempting to reset the authorization state by dispatching `resetAuth`. Unfortunately we haven't been dispatching the function call but rather the function/action-creator itself leading to no actionable dispatch. In this patch we're fixing the call by calling `resetAuth()` which then passes a real action to the dispatcher. This should fix an unsurfaced but during invalid authentication flows.
dmsnell
added a commit
that referenced
this pull request
Feb 22, 2020
* Fix: Actually reset auth when authorizing without acess token Discovered via TypeScript in #1884 Previously when authorizing an account which yields no `access_token` we have been attempting to reset the authorization state by dispatching `resetAuth`. Unfortunately we haven't been dispatching the function call but rather the function/action-creator itself leading to no actionable dispatch. In this patch we're fixing the call by calling `resetAuth()` which then passes a real action to the dispatcher. This should fix an unsurfaced but during invalid authentication flows. * Catch that other one too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only real change should be some optional-chaining.
Discovered a bug in
resetAuththat needs to be fixed outside of this branch.Testing
Should be no real code changes, no functional or visual changes.