Types: Add types to analytics module, fix module syntax #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belcherj
suggested changes
Feb 7, 2020
dmsnell
force-pushed
the
types/type-analytics
branch
from
c51ef3b to
e5fcaa2
Compare
The analytics module has been using a commonJS format and has been working "by accident"
because `webpack` properly translates the import/export syntax.
```js
// moduleA.js
const stuff = {
thing: 5;
}
module.exports = stuff;
// moduleB.js
import { thing } from 'moduleA'
```
^^^ that shouldn't work but it has been. This has been resolved in this commit.
dmsnell
force-pushed
the
types/type-analytics
branch
from
e5fcaa2 to
24a8296
Compare
|
In reviewing this I couldn't find out where the analytics were actually being sent. In fact I couldn't figure this out in production either. |
|
In a zoom @belcherj helped me find the place where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The analytics module has been using a commonJS format and has been working "by accident"
because
webpackproperly translates the import/export syntax.^^^ that shouldn't work but it has been. This has been resolved in this commit.
Testing
There should be no functional or visual changes in this PR. Some code will likely
change but only in the exports. It may not change once through
webpack.