Fix: Restore markdown preview button #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #1851 we refactored the selected note state but during testing missed a reference to `state.appState.note` which should have been updated to `state.ui.note`. Nothing crashed in the app because it was being used for its truthiness but the result was that when checking if Markdown was enabled for any given note the answer would always end up as "no." In this patch we're restoring the state reference which fixes that bug and restores the preview button in the note toolbar.
|
Thank you @dmsnell! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1851 we refactored the selected note state but during testing
missed a reference to
state.appState.notewhich should have beenupdated to
state.ui.note. Nothing crashed in the app because itwas being used for its truthiness but the result was that when
checking if Markdown was enabled for any given note the answer
would always end up as "no."
In this patch we're restoring the state reference which fixes that
bug and restores the preview button in the note toolbar.