Types: Add legacy action types #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When @belcherj asked about creating types for the existing actions in `app-state` I was reluctant since we want to get rid of them but then in considering his view I think it's the right decision until they are all gone; so I have created the types here. These are organized as one big `LegacyAction` type that isn't exported. This provides auto-completion and type-checking while still hiding the types somewhat. They are at the end of `action-types.ts` so that we can mostly ignore them. As we remove functionality from `app-state` we should remove the corresponding legacy action types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When @belcherj asked about creating types for the existing actions in
app-stateI was reluctant since we want to get rid of them but then inconsidering his view I think it's the right decision until they are all gone;
so I have created the types here.
These are organized as one big
LegacyActiontype that isn't exported. Thisprovides auto-completion and type-checking while still hiding the types
somewhat. They are at the end of
action-types.tsso that we can mostly ignorethem. As we remove functionality from
app-statewe should remove thecorresponding legacy action types.
Testing
There are only type changes in this PR and no code changes. The output code
should be identical and therefore no testing is needed beyond the smoke-testing
provided by our CI runners: if the app builds and runs it should be safe.