Move unsyncednoteids state from flux to redux #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
reviewed
Jan 29, 2020
| import { | ||
| setUnsyncedNoteIds, | ||
| toggleSimperiumConnectionStatus, | ||
| } from './state/ui/actions'; |
There was a problem hiding this comment.
should be able to import them all in one go if you find it easier
import * as actions from './state/actions';
dispatch( actions.ui.setUnsyncedNoteIds );There was a problem hiding this comment.
I like having them separated. If there were more than five or we had multiple /actions imports this would make sense to me.
belcherj
force-pushed
the
refactor/move-unsyncednoteids-to-redux
branch
from
55e7466 to
4ccf84c
Compare
dmsnell
approved these changes
Feb 3, 2020
There was a problem hiding this comment.
As a code-only review I haven't tested this. It's good to leave it like this for now, but hopefully in the future we'll rehaul how we detect this stuff. I'm pretty sure that node-simperium already gives us a way to trap unsync'd ids without deeply-coupling into it with our local-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Moves unsyncednoteids state from flux to redux
Test
Review