Types: Add core types to support Redux refactors #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a basic design for managing our Redux store in the typesystem and establishes norms for how to create new action types and reducers as well as how to add types to our React components and interact with Redux
belcherj
approved these changes
Jan 24, 2020
dmsnell
added a commit
that referenced
this pull request
Jan 24, 2020
In this patch we're adopting the changes in #1855 and updating legacy reducers, action types, and action creators. This serves both as a guide for adding new Redux pieces while improving the overall type-safety and completeness of the Redux subsystem in the app.
dmsnell
added a commit
that referenced
this pull request
Jan 24, 2020
In this patch we're adopting the changes in #1855 and updating legacy reducers, action types, and action creators. This serves both as a guide for adding new Redux pieces while improving the overall type-safety and completeness of the Redux subsystem in the app.
This was referenced Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a basic design for managing our Redux store in the typesystem
and establishes norms for how to create new action types and reducers as
well as how to add types to our React components and interact with Redux
There should be no functional or visible changes in this PR - this only adds
new types and documentation to the app and should have no impact on the
code produced.