Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Types to state ui actions #1849

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Add Types to state ui actions #1849

merged 2 commits into from
Jan 23, 2020

Conversation

belcherj
Copy link
Contributor

@belcherj belcherj commented Jan 20, 2020 •
edited
Loading

Fix

Adds types to state/ui/actions

Test

  1. Does the app build?

Review

Only one developer is required to review these changes, but anyone can perform the review.

Release

RELEASE-NOTES.txt was updated with:

  • Added types to state/ui/actions #1849

@belcherj belcherj self-assigned this Jan 20, 2020
@belcherj belcherj requested a review from a team January 20, 2020 19:10
dmsnell
dmsnell approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing troublesome here as long as we did basic tests on it.

@belcherj belcherj merged commit 5b501e7 into develop Jan 23, 2020
@belcherj belcherj deleted the add/types-state-ui-actions branch January 23, 2020 16:06
@codebykat codebykat added this to the state refactor milestone Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmsnell dmsnell dmsnell approved these changes

Assignees

@belcherj belcherj

Labels
None yet
Projects
None yet
Milestone
state refactor
Development

Successfully merging this pull request may close these issues.
3 participants
@belcherj @dmsnell @codebykat