Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Dependencies to latest #1848

Merged
merged 3 commits into from
Jan 27, 2020
Merged

Updates Dependencies to latest #1848

merged 3 commits into from
Jan 27, 2020

Conversation

belcherj
Copy link
Contributor

@belcherj belcherj commented Jan 20, 2020

Fix

Updates dependencies to latest

Test

  1. Run app, click around, look for errors

Review

Only one developer is required to review these changes, but anyone can perform the review.

Release

RELEASE-NOTES.txt was updated with:

  • Updated Dependencies #1848

@belcherj belcherj requested a review from a team January 20, 2020 15:51
@belcherj belcherj self-assigned this Jan 20, 2020
"wait-on": "3.3.0",
"style-loader": "1.1.3",
"typescript": "3.7.5",
"wait-on": "4.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we even need this? this is a major update so I checked to see what we'd need to change and it's not referenced anyway. it came in #859 with misty and I'm not sure if it was meant to be a transitive/peer dependency. I haven't tried building without it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the API changed but they rewrote the code thus the full point bump.

@belcherj belcherj force-pushed the update/dependencies branch from d9145d9 to e60ad06 Compare January 27, 2020 14:20
Copy link
Member

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke-tested, looks fine 👍

@belcherj belcherj merged commit 2e23711 into develop Jan 27, 2020
@belcherj belcherj deleted the update/dependencies branch January 27, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants