Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tag rename functionality #1834

Merged
merged 2 commits into from
Jan 14, 2020
Merged

Fix tag rename functionality #1834

merged 2 commits into from
Jan 14, 2020

Conversation

belcherj
Copy link
Contributor

@belcherj belcherj commented Jan 14, 2020 •
edited
Loading

Fix

There is a typo in the variable rename function that is causing tags to be set
as undefined on tag rename.

Test

  1. Add tag to a site
  2. Change the tag name
  3. Observe that tag is renamed o the ote

Review

Only one developer is required to review these changes, but anyone can perform the review.

Release

RELEASE-NOTES.txt was updated with:

  • Fixed tag rename functionality #1834

@belcherj
Fix tag rename functionality
f95b54b 
There is a typo in the variable rename function that is causing tags to be set
as undefined on tag rename.
@belcherj belcherj requested a review from a team January 14, 2020 13:28
@belcherj belcherj self-assigned this Jan 14, 2020
dmsnell
dmsnell approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this - it looks like I introduced it in #1638 by accident.

@belcherj belcherj merged commit ee3c63e into develop Jan 14, 2020
@dmsnell dmsnell deleted the fix/tag-rename branch January 14, 2020 22:40
@codebykat
Copy link
Member

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmsnell dmsnell dmsnell approved these changes

Assignees

@belcherj belcherj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@belcherj @codebykat @dmsnell