Refactor tag suggestions #1827
Merged
Refactor tag suggestions #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this patch we're creating some new tests to verify the expected way that the search field will filter down available tags. This is to help us make updates to the tag searching and suggesting interface.
dmsnell
changed the title
I've removed the RegExp and rewritten the filtering loop. Why? The RegExp added a step of confusion where we needed to parse and understand what it was doing. It turns out that in the course of this refactor I found a case where it wasn't doing what we thought it was doing, skipping a full-text match for `tag:` given a tag named `tag:`. Without the RegExp we simply have fewer concepts squished into this function. The filtering loop also was iterating over every tag in the account and checking if they matched the search query before it thought about pruning down the list of matches to the maximum number. With the new loop we're using a helper function (to keep the looping details out of the logic) which will abort out of its looping as soon as we find as many results as we'll allow. Otherwise if it never finds the maximum results it will continue iterating until it has scanned every tag. One final bug was fixed: it was previously possible to enter whitespace into the search field and then it would look for all of the tags as possible matches. With only whitespace in the search field there should be no tag suggestions.
dmsnell
force-pushed
the
tests/tag-suggestions
branch
from
1a270ab to
cead920
Compare
codebykat
approved these changes
Jan 12, 2020
This was referenced Jan 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this patch we're creating some new tests to verify the expected way that the
search field will filter down available tags. This is to help us make updates
to the tag searching and suggesting interface.
Testing
That's what this is! Check the CI build.