Refactor(NoteList): Use createRef() instead of ref function
#1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
force-pushed
the
refactor/note-list-create-ref
branch
from
429e8d4 to
a1db2b1
Compare
belcherj
approved these changes
Jan 6, 2020
dmsnell
force-pushed
the
refactor/note-list-create-ref
branch
from
a1db2b1 to
ee7aa22
Compare
|
Updated to rebase |
Keeping up with React standards. This patch replaces the use of a ref function with a `createRef()`. This will end up making our types easier. This is part of broader work to separate modifying the search parameters from actually filtering the notes and was originally created as part of an exploratory PR #1807.
dmsnell
force-pushed
the
refactor/note-list-create-ref
branch
from
ee7aa22 to
74bbffc
Compare
|
Rebased to catch file rename in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping up with React standards. This patch replaces the use of a ref function
with a
createRef(). This will end up making our types easier.This is part of broader work to separate modifying the search parameters from
actually filtering the notes and was originally created as part of an
exploratory PR #1807.
Testing
This is a small change. Smoke test by moving around the notes list.