Use name attribute not the deprecated getter function #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belcherj
force-pushed
the
update/use-name-attribute-not-getter
branch
from
3d0f819 to
4aea13b
Compare
belcherj
changed the title
https://electronjs.org/docs/all#appgetname is deprecated, https://electronjs.org/docs/all#appname should be used instead. This PR replaces uses of `.getName()` with `.name`.
belcherj
force-pushed
the
update/use-name-attribute-not-getter
branch
from
4aea13b to
9d1e262
Compare
dmsnell
approved these changes
Feb 11, 2020
belcherj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
https://electronjs.org/docs/all#appgetname is deprecated,
https://electronjs.org/docs/all#appname should be used instead. This PR
replaces uses of
.getName()with.name.Test
Open built dmg from ci and ensure the App name in the context menu is correct.