Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git hooks to run formats, lints, and tests #1790

Merged
merged 3 commits into from
Dec 18, 2019
Merged

Add git hooks to run formats, lints, and tests #1790

merged 3 commits into from
Dec 18, 2019

Conversation

belcherj
Copy link
Contributor

Fix

Don't use prettier in your editor? Forget to run the linter and tests before pushing? We all do it from time to time. Well, I got you covered!

  • Run prettier automagically when committing, you don't need to anything it will do it for you and add those changes to your commit
  • Run the linter on push
  • Run the tests on push

Test

  1. Add a change that prettier would fix
  2. Commit
  3. Observe that it gets fixed in the commit
  4. git push and observe that it runs lints and tests!

Review

Only one developer ais required to review these changes, but anyone can perform the review.

Release

RELEASE-NOTES.txt was updated with:

  • Added git hooks to run format, lints, and tests

@belcherj belcherj requested a review from dmsnell December 18, 2019 18:35
@belcherj belcherj self-assigned this Dec 18, 2019
dmsnell
dmsnell approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good updates. Should save us some embarrassment.

@belcherj belcherj merged commit c6ffe9d into develop Dec 18, 2019
@belcherj belcherj deleted the add/git-hooks branch December 18, 2019 19:38
@codebykat codebykat added this to the 1.14 milestone Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmsnell dmsnell dmsnell approved these changes

Assignees

@belcherj belcherj

Labels
None yet
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
3 participants
@belcherj @dmsnell @codebykat