Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint plugin for React Hooks #1789

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Add eslint plugin for React Hooks #1789

merged 2 commits into from
Dec 18, 2019

Conversation

belcherj
Copy link
Contributor

@belcherj belcherj commented Dec 18, 2019 •
edited
Loading

Fix

Add eslint plugin for React Hooks

Test

  1. npm install
  2. npm runn lint

Review

Only one developer is required to review these changes, but anyone can perform the review.

Release

RELEASE-NOTES.txt was updated with:

  • Added React Hooks Eslinnt Plugin #1789

@belcherj belcherj requested a review from dmsnell December 18, 2019 17:57
dmsnell
dmsnell approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I welcome the lint rules which can catch subtle and complicated nuances of React Hooks, though I hope that we can be very cautious and guarded about adopting hooks generally. Let's chat in Slack about it.

@belcherj belcherj merged commit e068b48 into develop Dec 18, 2019
@belcherj belcherj deleted the add/hooks-liter-rules branch December 18, 2019 18:40
@codebykat codebykat added this to the 1.14 milestone Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmsnell dmsnell dmsnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
3 participants
@belcherj @dmsnell @codebykat