Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the prettier command and applies prettier fixes #1780

Merged
merged 4 commits into from
Dec 16, 2019

Conversation

belcherj
Copy link
Contributor

@belcherj belcherj commented Dec 16, 2019

Fix

The prettier command was not properly checking all files under code revision.
It was only checking files that were one layer deep. This updates the command
so that it runs on all files and applies formatting to those files

Test

Does app run?

Review

Only one developer is required to review these changes, but anyone can perform the review.

Release

RELEASE-NOTES.txt was updated with:

  • Applied prettier formatting to all files #1780

The prettier command was not properly checking all files under code revision.
It was only checking files that were one layer deep. This updates the command
so that it runs on all files and applies formatting to those files
@belcherj belcherj requested a review from a team December 16, 2019 18:46
@belcherj belcherj self-assigned this Dec 16, 2019
Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good update!

@belcherj belcherj merged commit 071f0c7 into develop Dec 16, 2019
@dmsnell dmsnell deleted the fix/prettier-format-command branch January 16, 2020 03:16
@codebykat codebykat added this to the 1.14 milestone Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants