Remove code that stops settings from scrolling on shorter screens #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point, some code was added that allowed the tabs to scroll. In adding this it caused the settings tab to display at full height and not be contained by the scroll box in the modal. This fixes https://href.li/?https://github.com/Automattic/simplenote-electron/issues/1268
codebykat
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
At some point, some code was added that allowed the tabs to scroll. In adding
this it caused the settings tab to display at full height and not be contained
by the scroll box in the modal. This fixes
https://href.li/?https://github.com/Automattic/simplenote-electron/issues/1268
This is not a long term solution as it is still not a great user experience. We need to drop the modals for full-page settings.
Test
Old, doesn't scroll:
After, scrolls:
Review
Only one developer is required to review these changes, but anyone can perform the review.
Release
RELEASE-NOTES.txtwas updated with: