Build: stop failing the build on eslint errors #1594
Conversation
|
Related #1596 |
This is on my list of wants. Seems like an easy GitHub Action. I will follow up with a precommit hook as I've written that code a number of times. Probably won't get to the server check for a while. |
| enforce: 'pre', | ||
| use: [ | ||
| { | ||
| loader: 'eslint-loader', |
There was a problem hiding this comment.
This is likely a dependency that can be removed as well.
There was a problem hiding this comment.
removed dependency in 065321e
`eslint` provides helpful warnings that prevent bugs in our software. However by running it as a precondition for the build we introduce artificial obstacles to quick testing and iteration. For instance, we will fail to build the app if we have an unused variable even though there's no reason it would break the build. In this change we're removing the precondition for passing `eslint` before building the app. This should allow us to more rapidly made small debugging/testing adjustments while working on fixing or altering the app. `eslint` still belongs in the process and we might follow-up on this PR by introducing it as a `git` hook on `precommit`, a more appropriate place for the safety check. For now though I am foregoing that work in order to remove what has been a persistent frustration while working on the app.
dmsnell
force-pushed
the
build/stop-failing-build-on-eslint-error
branch
from
c30225b to
065321e
Compare
|
|
eslintprovides helpful warnings that prevent bugs in our software.However by running it as a precondition for the build we introduce
artificial obstacles to quick testing and iteration. For instance, we
will fail to build the app if we have an unused variable even though
there's no reason it would break the build.
In this change we're removing the precondition for passing
eslintbefore building the app. This should allow us to more rapidly made small
debugging/testing adjustments while working on fixing or altering the
app.
eslintstill belongs in the process and we might follow-up on this PRby introducing it as a
githook onprecommit, a more appropriateplace for the safety check. For now though I am foregoing that work in
order to remove what has been a persistent frustration while working on
the app.
This should have no visual or functional change on the app. This should
only impact the build of the application while developing and debugging.